-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: timer-not-working #101 #102
fix: timer-not-working #101 #102
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @Utkarshn10 on Vercel. @Utkarshn10 first needs to authorize it. |
@Utkarshn10 first needs to authorize it. sorry accidentally clicked, i will not make these mistakes anymore in the future. consider my PR and not my mistakes. as a beginner i am exploring all of these. not going to spoil anything |
Thanks @KSSaiTeja for contributing to Focusly :) |
Thanks for accepting my PR. @Utkarshn10 can i share it on my socials.. and also i have some ideas to improve focusly.. to more beautiful UI.. i want share those ideas with you. could you please tell me how can i share those ideas to you |
my Pleasure.. |
Related Issue
Closes: #101 that will be closed through this PR
Describe the changes you've made
Give a clear description what modifications you have made
I have created
audioRef
to reference the<audio>
element in the component.handlePlaySound
plays the audio if it's not already playing and starts the timer.handleStopSound
stops the audio if it's playing, resets the timer, and sets soundPlaying to false to indicate that the sound has stopped. and the timer stopped issue is also fixedType of change
Bug fix
What sort of change have you made:
How Has This Been Tested?
yes! i tested it and it absolutely working fine when i am tested. if this PR gets accepted i will suggest some more new features i have and i will contribute more to this. Please review the changes and accept the PR. sorry i worked without assigning the issue the task to me. As it is not mentioned in contributing guidelines so that's why i raised a PR. As i am a beginner i don't know if it is correct or not, if it is not correct excuse me for this time, and sorry for disrupting the community guidelines.
Describe how have you verified the changes made
by running the project locally,
npm install --legacy-peer-deps
after that making some file changes and thennpm start
Checklist:
Video Proof of what i have done (ignore the interruption they are just hydration errors, they will not come in production.)
Screen.Recording.2023-08-20.at.1.58.00.AM.mov
previoulsy the timer fluctuates and not worked when morethan one music playing. but i fixed this, to any one of the music is playing the timer will run, when no music is playing the timer will stop.