Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: new sounds added #104

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

KSSaiTeja
Copy link
Contributor

Some new sounds added.. please check.. let me know if they're ok.. i will raise another PR.. by adding those sounds

@vercel
Copy link

vercel bot commented Aug 29, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Utkarshn10 on Vercel.

@Utkarshn10 first needs to authorize it.

Copy link
Owner

@Utkarshn10 Utkarshn10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KSSaiTeja please name the sounds based on the names you are going to keep in cards.

@KSSaiTeja
Copy link
Contributor Author

@Utkarshn10 i have changed the files names.. please check and let me know..

Copy link
Owner

@Utkarshn10 Utkarshn10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved.

@Utkarshn10 Utkarshn10 merged commit 15b7e51 into Utkarshn10:master Aug 31, 2023
1 of 2 checks passed
@KSSaiTeja
Copy link
Contributor Author

Thanks for merging my PR..

should i add those sounds to the focusly

@Utkarshn10
Copy link
Owner

Yes please go ahead.

@KSSaiTeja
Copy link
Contributor Author

ok then.. i will start adding those sounds under LO-FI tab

@KSSaiTeja
Copy link
Contributor Author

i have raised new PR with another branch please check and merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants