Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: fix(ImageBaseOverlay): fix nested Tappable (#7006) | #7152

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Jul 8, 2024

@BlackySoul BlackySoul requested a review from a team as a code owner July 8, 2024 12:48
Copy link
Contributor

github-actions bot commented Jul 8, 2024

size-limit report 📦

Path Size
JS 369.29 KB (+0.18% 🔺)
JS (gzip) 113.09 KB (+0.17% 🔺)
JS (brotli) 93.1 KB (+0.17% 🔺)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 290 KB (+0.05% 🔺)
CSS (gzip) 37.72 KB (+0.06% 🔺)
CSS (brotli) 30.47 KB (+0.13% 🔺)

Copy link

codesandbox-ci bot commented Jul 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jul 8, 2024

👀 Docs deployed

Commit c7b0acd

* fix(ImageBaseOverlay): fix nested Tappable

* fix(ImageBaseOverlay): add non interactive wrapper

* chore: clean up

Co-authored-by: Andrey Medvedev <andr.medv.spb@gmail.com>

* chore: fix prettier

* fix: review notes

* fix merge

* fix: remove tests

* fix: revert DisableClickableLockStateContext  adding

---------

Co-authored-by: Andrey Medvedev <andr.medv.spb@gmail.com>
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (6.2-stable@b073303). Learn more about missing BASE report.

Files Patch % Lines
...src/components/ImageBase/ImageBaseOverlay/hooks.ts 76.92% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             6.2-stable    #7152   +/-   ##
=============================================
  Coverage              ?   83.79%           
=============================================
  Files                 ?      358           
  Lines                 ?    10709           
  Branches              ?     3556           
=============================================
  Hits                  ?     8974           
  Misses                ?     1735           
  Partials              ?        0           
Flag Coverage Δ
unittests 83.79% <93.02%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul force-pushed the blackysoul/cherry-pick-7006 branch from e0d3f24 to f360d12 Compare July 8, 2024 12:58
@BlackySoul BlackySoul marked this pull request as draft July 8, 2024 13:48
@BlackySoul BlackySoul marked this pull request as ready for review July 8, 2024 13:48
SevereCloud
SevereCloud previously approved these changes Jul 8, 2024
@BlackySoul BlackySoul merged commit 5019c30 into 6.2-stable Jul 8, 2024
26 checks passed
@BlackySoul BlackySoul deleted the blackysoul/cherry-pick-7006 branch July 8, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants