Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: GET_ORDERED_ALL_CHARACTERS_INFOを統合 #1819

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sevenc-nanashi
Copy link
Member

内容

速度的にもあまり変わらない(ソース)ので統合します。

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner February 2, 2024 11:57
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team February 2, 2024 11:57
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

src/components/Talk/EditorHome.vue Outdated Show resolved Hide resolved
src/components/Talk/EditorHome.vue Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よくよく見てみるとORDEREDは必要な気がしてきました。。。
いやまあMapはたしか順序が維持されるので、今のコードなら実は順序大丈夫なのですが、変えちゃだめなことに気づけないなと・・・

ORDEREDの方だけにして、Mapの方はORDEREDから作るとか・・・・?

Comment on lines 166 to 170
// サンプルの順番、新しいキャラクターは上に
sampleCharacterOrder.value = [
...newCharacters.value,
...props.characterInfos
...characterInfosArray.value
.filter(
Copy link
Member

@Hiroshiba Hiroshiba Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こーーーーーーれ、characterInfosArrayはorderedな必要がある気がしてきました・・・・・・・。
(順番が大事っぽい。)

Comment on lines 169 to 173
<default-style-list-dialog
v-if="orderedTalkCharacterInfos.length > 0"
v-if="allTalkCharacterInfos.length > 0"
v-model="isDefaultStyleSelectDialogOpenComputed"
:character-infos="orderedTalkCharacterInfos"
:character-infos="allTalkCharacterInfos"
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こっちも実はorderedじゃないといけない説が・・・・・・・?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants