Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: トラック毎の書き出しを追加 #2228

Merged
merged 44 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
671f52c
Add: トラック毎書き出しを追加
sevenc-nanashi Aug 18, 2024
d93e31b
Add: ファイル名設定を追加
sevenc-nanashi Aug 18, 2024
e4b4a3f
Add: パラメータ適用の切り換えを追加
sevenc-nanashi Aug 18, 2024
ffa5035
Delete: パラメータ書き出し周りを削除
sevenc-nanashi Aug 24, 2024
74a34dd
Change: デフォルトの書き出しファイル名にキャラ名を追加
sevenc-nanashi Aug 26, 2024
456fa43
Code: applyTrackParameters -> shouldApplyTrackParameters
sevenc-nanashi Aug 26, 2024
7a6d6c6
Change: DialogCell -> DialogButtonCell
sevenc-nanashi Aug 26, 2024
ed17385
Change: throwする
sevenc-nanashi Aug 26, 2024
f41ac76
Code: スタイル修正
sevenc-nanashi Aug 26, 2024
9166ab7
Code: buildFileName -> fileNameBuilder
sevenc-nanashi Aug 26, 2024
ab3e0ec
Refactor: 共通化
sevenc-nanashi Aug 26, 2024
02e619f
Change: DialogButtonCell -> EditButtonCell
sevenc-nanashi Sep 2, 2024
fdff200
Change: propsを変える
sevenc-nanashi Sep 2, 2024
eac3d15
Code: 定義を移動
sevenc-nanashi Sep 2, 2024
9d7e724
Change: click -> buttonClick
sevenc-nanashi Sep 3, 2024
e1c5ac6
Change: ファイル名のフォーマットあたりを変える
sevenc-nanashi Sep 3, 2024
06efbf4
Merge: upstream/main -> add/stem-export
sevenc-nanashi Sep 4, 2024
d426919
Fix: 上流からのマージのエラーを修正
sevenc-nanashi Sep 4, 2024
5af928d
Refactor: 変数名を整理
sevenc-nanashi Sep 4, 2024
6864b52
Change: FileNamePatternDialog -> FileNameTemplateDialog
sevenc-nanashi Sep 4, 2024
9a0e858
Refactor: props周りを整理
sevenc-nanashi Sep 5, 2024
5324496
Fix: 初期値が反映されないのを修正
sevenc-nanashi Sep 5, 2024
30616e7
Fix: value忘れ
sevenc-nanashi Sep 6, 2024
3b336e6
Add: storyを追加
sevenc-nanashi Sep 6, 2024
e9f2b7c
Code: コメントを追加
sevenc-nanashi Sep 6, 2024
2cb5f55
Update: test-runnerを更新してみる
sevenc-nanashi Sep 6, 2024
0c64861
Add: patchを追加
sevenc-nanashi Sep 7, 2024
d1599af
Fix: fnを消す
sevenc-nanashi Sep 7, 2024
153a0c3
Delete: patchを消す
sevenc-nanashi Sep 7, 2024
a9c8729
Revert: patchを戻す
sevenc-nanashi Sep 7, 2024
145835a
Delete: fnを消す
sevenc-nanashi Sep 7, 2024
c340ba8
Fix: patchしてない範囲があったので修正
sevenc-nanashi Sep 8, 2024
ee1f05f
Add: コメントを追加
sevenc-nanashi Sep 8, 2024
456d1d8
Delete: 不要な分岐を削除
sevenc-nanashi Sep 8, 2024
f91ab93
Code: patchのコメントを足す
sevenc-nanashi Sep 9, 2024
b1b3055
Change: findByTextにしてみる
sevenc-nanashi Sep 9, 2024
e2cde6d
Change: patch-packageを明示的に実行しないようにする
sevenc-nanashi Sep 9, 2024
532e2f2
Refactor: clearAndInputに共通化
sevenc-nanashi Sep 9, 2024
9dcc8f8
Fix: awaitする
sevenc-nanashi Sep 9, 2024
423e4c3
Change: toBeInTheDocumentにする
sevenc-nanashi Sep 9, 2024
b610fe4
Fix: やっぱりpatch-packageする
sevenc-nanashi Sep 9, 2024
a8956a2
Change: patchesを移動
sevenc-nanashi Sep 10, 2024
6754aac
Code: コメントを追加
sevenc-nanashi Sep 10, 2024
dd7fae6
Apply suggestions from code review
Hiroshiba Sep 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions build/patches/@storybook+test-runner+0.19.1.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
メモ:
test-storybookが`page.evaluate: ReferenceError: __test is not defined`エラーで落ちるのを防止する。
https://github.com/storybookjs/test-runner/issues/68#issuecomment-2224900181 のワークアラウンド。

diff --git a/node_modules/@storybook/test-runner/dist/index.js b/node_modules/@storybook/test-runner/dist/index.js
index accc363..ce1e3e9 100644
--- a/node_modules/@storybook/test-runner/dist/index.js
+++ b/node_modules/@storybook/test-runner/dist/index.js
@@ -13566,7 +13566,7 @@ var testPrefixer = /* @__PURE__ */ __name((context) => {
await globalThis.__sbPreVisit(page, context);
}

- const result = await page.evaluate(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
+ const result = await page.addInitScript(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
id: %%id%%,
});

diff --git a/node_modules/@storybook/test-runner/dist/index.mjs b/node_modules/@storybook/test-runner/dist/index.mjs
index 3bef978..d3fc1cf 100644
--- a/node_modules/@storybook/test-runner/dist/index.mjs
+++ b/node_modules/@storybook/test-runner/dist/index.mjs
@@ -13549,7 +13549,7 @@ var testPrefixer = /* @__PURE__ */ __name((context) => {
await globalThis.__sbPreVisit(page, context);
}

- const result = await page.evaluate(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
+ const result = await page.addInitScript(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
id: %%id%%,
});

diff --git a/node_modules/@storybook/test-runner/dist/test-storybook.js b/node_modules/@storybook/test-runner/dist/test-storybook.js
index f5f2a8f..606cdfe 100755
--- a/node_modules/@storybook/test-runner/dist/test-storybook.js
+++ b/node_modules/@storybook/test-runner/dist/test-storybook.js
@@ -17623,7 +17623,7 @@ var testPrefixer = /* @__PURE__ */ __name((context) => {
await globalThis.__sbPreVisit(page, context);
}

- const result = await page.evaluate(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
+ const result = await page.addInitScript(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
id: %%id%%,
});

diff --git a/node_modules/@storybook/test-runner/dist/test-storybook.mjs b/node_modules/@storybook/test-runner/dist/test-storybook.mjs
index 2ac7d7a..328f157 100755
--- a/node_modules/@storybook/test-runner/dist/test-storybook.mjs
+++ b/node_modules/@storybook/test-runner/dist/test-storybook.mjs
@@ -17629,7 +17629,7 @@ var testPrefixer = /* @__PURE__ */ __name((context) => {
await globalThis.__sbPreVisit(page, context);
}

- const result = await page.evaluate(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
+ const result = await page.addInitScript(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
id: %%id%%,
});

230 changes: 222 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"electron:serve": "cross-env VITE_TARGET=electron vite",
"browser:serve": "cross-env VITE_TARGET=browser vite",
"browser:build": "cross-env VITE_TARGET=browser vite build",
"postinstall": "electron-builder install-app-deps && node build/download7z.js",
"postinstall": "patch-package --patch-dir build/patches && electron-builder install-app-deps && node build/download7z.js",
"postuninstall": "electron-builder install-app-deps",
"license:generate": "node build/generateLicenses.js",
"license:merge": "node build/mergeLicenses.js",
Expand Down Expand Up @@ -80,7 +80,7 @@
"@storybook/addon-themes": "8.1.10",
"@storybook/blocks": "8.1.10",
"@storybook/test": "8.1.10",
"@storybook/test-runner": "0.19.0",
"@storybook/test-runner": "0.19.1",
"@storybook/vue3": "8.1.10",
"@storybook/vue3-vite": "8.1.10",
"@types/async-lock": "1.4.0",
Expand Down Expand Up @@ -115,6 +115,7 @@
"happy-dom": "8.4.2",
"license-checker-rseidelsohn": "4.3.0",
"markdownlint-cli": "0.37.0",
"patch-package": "8.0.0",
"prettier": "3.2.5",
"sass": "1.32.13",
"storybook": "8.1.10",
Expand Down
Loading
Loading