-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin] LargeProfileAvatars #1976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be a good idea to add css fallbacks incase discord update UI but that's up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh also, add a README.md for your plugin!
Co-authored-by: ant0n <antonickadoo@gmail.com>
This can be done with css |
Correct me if I’m wrong, but css will not be able to change the resolution of the avatar which is why this is a plugin and not just a theme. |
I don't think you can change the resolution but most pfps are high enough resolution already, either way this doesn't feel like it should be a whole plugin |
Discord only grabs the picture in 80x80px by default this plugin makes it user selectable. |
Turns out the patch is kinda flawed so I’m closing this so I can rework it. |
Completely rewrote the patch such that it no longer touches chat avatars |
I like this idea, would probably need a completely new patch since it would probably be better to try to add it to all avatarstack elements so that it could be used in more places. I'll keep this PR open for the time being (if that's alright) but I assume it would be better to open a new one for the addition to ThemeAttributes. |
assuming this can be closed now as superseded by #2449? |
Makes avatars take up the full width of the profile modal and renders them in higher resolution.