Fix #1290: Ignore only class level parameters in NUnit tests is not possible #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-englert
force-pushed
the
issues/#1290
branch
2 times, most recently
from
773a03e
to
d28c16d
Compare
i dont think this is true. the parameters passed in are used to prevent conflicts in received files |
|
I see, maybe this was only true for NUnit, because there UseParameters is optional... |
…ts is not possible => New setting "IgnoreParameters" allows to ignore explicit parameters.
tom-englert
force-pushed
the
issues/#1290
branch
from
d28c16d
to
7c21327
Compare
|
OK, introduced a new setting, so it does not collide with the original one |
|
thanks. will include in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will introduce a new setting
IgnoreParameters, the parameters of this setting are the names of the parameters to be ignored.The method
UseParametersis expected to always contain all parameters, even if some of them will be ignored!Also
UseParametersneeds to be called along withIgnoreParametersfor test frameworks that do not support automatic parameter detection like NUnit.