Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our ex_coveralls with forked master branch #2

Merged
merged 28 commits into from
Sep 27, 2024

Conversation

tonyrud
Copy link

@tonyrud tonyrud commented Sep 26, 2024

Updates the branch we use for excoveralls in vetspire api repo to latest from the forked repo

gorghoa and others added 27 commits March 27, 2023 20:32
* Cobertura now handles defprotocol and defimpl definitions

* Cobertura, catch all if module type is unknown
* Update Elixir requirement to 1.11+

* Update deps
* Replace hackney with httpc

* SSL options

* FIXUP

* Cache fixed

* Aaaah, caching again

* FIXUP

* Add missing apps to :extra_applications

* Add better check for :public_key
Prior to 2.0 being released, `genhtml` was much better about handling
source files from the following paths:

* `test/support/some_helper.ex`
* `lib/foo/bar.ex`

But after 2.0 was released, when rendering with `genhtml` the paths
would be mangled and look like the following:

* `test/support/test/support/some_helper.ex`
* `lib/foo/lib/foo/bar.ex`

I have tried in vain with many permutations of `--prefix` when running
`genhtml` but the ultimate fix that made all of this go away was using
the absolute path for the source file (`SF`).
…#309)

* Import `.coverdata` after test run and improve docs

* Update README table of contents

* Update README based on review suggestion

Co-authored-by: Alberto Sartori <alberto.sartori.as@gmail.com>

---------

Co-authored-by: Alberto Sartori <alberto.sartori.as@gmail.com>
* Accept custom http options

* Add HTTP options docs to README
* Always floor coverage instead of rounding

We do not want to report a 100% coverage when there are lines
that are not covered.

* Add option to restore previous ceil coverage behaviour
* Detect and warn about incorrectly used ignore-comments

Resolves parroty#197.

* Keep existing ignoring behavior

* Improve formatting

* Test more ignore-related warnings

* Remove warning in the case of ignore-next-line at the EOF

* Test the warning output

* Add a changelog entry

* Adjust test descriptions

---------

Co-authored-by: Roman <205906+RKushnir@users.noreply.github.com>
Without this change, the output is full of warnings such as
```
warning: negative steps are not supported in String.slice/2, pass 44..-1//1 instead
```
* add missing step for Cobertura's range

* Update Range to use function syntax

* run tests in elixir 1.17

* fix test with relative path

---------

Co-authored-by: parroty <parroty@users.noreply.github.com>
@tonyrud tonyrud requested a review from vereis September 26, 2024 15:17
@tonyrud tonyrud changed the base branch from master to vetspire-base September 26, 2024 15:17
@tonyrud tonyrud merged commit 3ec03e5 into vetspire-base Sep 27, 2024
@tonyrud tonyrud deleted the parroty-master branch September 27, 2024 12:32
@tonyrud
Copy link
Author

tonyrud commented Sep 27, 2024

Adding a note that I accidentally squash merged this and lost all of the commits from the base excoveralls changes 🤦 Chatted with Chris and force pushed these changes right to the base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.