centered text in get_img_for_tweet.py using textwrap #116
Conversation
There was a problem hiding this comment.
Wow, there are a lot of files that changed here. Typically, pull requests should focus on one thing.
- I haven't used
textwrapbefore. Good idea - What are all the
pycachefiles for? Are they necessary? - What is the purpose for the changes to
tweet.py? - Thanks for fixing the spelling in the comments
|
Sorry about that. The pycache should have been excluded from push. Forgot to add that to my gitignore. I'll revert the changes to the tweet.py and resubmit. I didn't intend to edit it. I was testing the twitter functionality, but on Windows used dotenv instead of environ[] which had a few changes. Thanks for checking it. |
There was a problem hiding this comment.
Fantastic! Thanks for all your work
Don't forget to follow the bot on Twitter to see the hard work you put in.
|
I figured as much that the pycache files weren't necessary, but thought I'd ask because I don't know everything. Thanks for your contribution! |
I tried to maintain the existing calculation details (i.e.: 35 character length / centered for loop checks for <20 char and >286) and focus only on dynamically determining the center and the offset given the image. I've replaced the individual checks for character length per line with the python texwrap function which does some of the heavy lifting. Hope this helps.