improve handling missing credentials by fixing missed configuration vali... #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidator checker removed the configuration checking code from the parse function of the provider class AwsS3Provider to the helper class CdnHelper and update the validator to check for any required configuration if missed and throw an exception Issue: #10
|
It's a good idea to have the |
added 3 commits
September 5, 2014 17:07
- remove configuration validate from helper class and create a configuration validator class to validate the configurations - rename $required_configurations to $rules in the amazon provider class Fix #12
- fix the small styling problem - add link to packagist
Mulkave
added a commit
that referenced
this pull request
Sep 5, 2014
improve handling missing credentials by fixing missed configuration vali...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also on issue #10 this branch fix the handling of missed credentials and missed configuration
removed the configuration checking code from the parse function of the
provider class AwsS3Provider to the helper class CdnHelper
and update the validator to check for any required configuration if missed
and throw an exception
Issue: #10