-
Notifications
You must be signed in to change notification settings - Fork 128
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove adding test options to the project/build target name hash (#3107)
* Remove adding test options to the project/build target name hash - this should not be put there. The hash in the build target name is used to introduce hashing when buildOptions are changed from the CLI. Otherwise, if options are changed from sources, Bloop recompiles the project anyway because the sources changed. Adding this new hash that comes from sources possibly creates new build targets every time somebody fiddles with some test scope options. It's just nonsense. Also look at the comments in the code, we've made a rule and then stopped following it. * Apply scalafix * Add test for the number of build targets created when changing options from cli and from sources * Format
- Loading branch information
1 parent
58f5a76
commit 6826e67
Showing
2 changed files
with
52 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters