Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small GUI change #660

Open
wants to merge 20 commits into
base: android
Choose a base branch
from
Open

Small GUI change #660

wants to merge 20 commits into from

Conversation

ikhoeyZX
Copy link

@ikhoeyZX ikhoeyZX commented Jul 31, 2024

  • Recenter overlay window and button
  • Add close button in overlay menu (because [x] too small and sometimes hard to pressed)
  • Allow scrolling in controller menu (because i did tried slide scroll slider at right, sometimes work and sometimes undetected because too small)
  • hide "debug" in menubar (it useless for end user and configuration button cant be pressed when multiwindows or freewindow mode because freewindows/multiwindow overide it or camera block it) > this one usefull for people have issue with builtin driver (adreno user) because they cant run fullscreen before install driver
  • allow resize joystick only instead all button
  • allow fallback to default driver in case custom driver broken (adreno only)
  • allow performance mode (may fix some device that have issue with locked in small core than big core)
  • cutout mode set to "shortEdges" (so it will draw full screen now, no black bar)
  • fix shortcut icon issue

example preview:
Screenshot_20240820_115411_Vita3K ZX

screen-20240820-115552.mp4

IMG-20240731-WA0000
IMG-20240731-WA0001
IMG-20240731-WA0003

VID-20240731-WA0002.mp4

@@ -1062,7 +1062,7 @@ void draw_live_area_screen(GuiState &gui, EmuEnvState &emuenv) {
const auto SELECT_SIZE = ImVec2(GATE_SIZE.x - (10.f * SCALE.x), GATE_SIZE.y - (5.f * SCALE.y));
const auto SELECT_POS = ImVec2(GATE_POS.x + (5.f * SCALE.y), GATE_POS.y + (2.f * SCALE.y));

const auto BUTTON_SIZE = ImVec2(72.f * SCALE.x, 30.f * SCALE.y);
const auto BUTTON_SIZE = ImVec2(80.f * SCALE.x, 55.f * SCALE.y);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need change it, problem here is not size, is how button size is scalled on android, because code for respect aspect ratio is disable on android
i not have this problem in my side
Buton size is all time same and fine

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my phone that button was hard to press, most often vita3k notification got pressed instead esc.
or should i move a bit lower instead resize it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants