Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK for M1 users #378

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Fix SDK for M1 users #378

merged 5 commits into from
Sep 28, 2022

Conversation

Selerski
Copy link
Contributor

@Selerski Selerski commented Sep 28, 2022

resolves https://github.com/VorTECHsa/app-issues/issues/1969

Tests:

  • spun up Python SDK locally with Python 3.8 and 3.9
  • ran the full SDK local test suite - no issues on an M1 mac
  • ran the CI tests - no issues either

@Selerski Selerski marked this pull request as ready for review September 28, 2022 11:27
CONTRIBUTING.md Outdated
@@ -79,6 +81,16 @@ $ pre-commit install

:tada: Now you're ready to create a new branch, add a feature or fix a bug, then send us a pull request! :tada:

### Note about Apple ARM-based chips

To run the SDK on an Apple ARM chip, upgrade your Python version to 3.8 or higher and use the latest version of pip.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add sth like this to remind user to use python 3.8 or higher in the readme.md?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and use 0.41.0 or higher version of the sdk

@Selerski Selerski merged commit eab755e into master Sep 28, 2022
@Selerski Selerski deleted the fix-m1-sdk branch September 28, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants