Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application updates for v6.2 release #67

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Conversation

dforbush2
Copy link
Contributor

@dforbush2 dforbush2 commented Sep 11, 2024

Adding one fix per commit
Listing broken library links for future reference.

  1. Controls MPC: exactly library body block + excitation force "GoTo" block to feed "From" in MPC.
  2. WECCCOMP MPC: same as 1).

The MOST simulation is failing checks as compared to logged data, and does not have any broken library links.
In all observed cases these errors were relatively small but larger than the specified tolerance. I suggest we merge now and revisit/revise these failing tests. I believe this could be the result of the initial optimization steps converging differently.

@kmruehl
Copy link
Contributor

kmruehl commented Sep 12, 2024

@dforbush2 thank you, I'll merge this shortly and we can look into what's going on with the MOST cases

@dforbush2 dforbush2 marked this pull request as draft September 12, 2024 20:01
@dforbush2
Copy link
Contributor Author

This PR is for merge once full directional spectra is working in all applications cases. It is not currently.
I will make another that SHOULD be merged after WEC-Sim Dev is reverted to 6.1 release state to fix the failing controls and WECCCOMP cases.

@kmruehl kmruehl changed the title Application error fixing with v6.1 updates Application updates for v6.2 release Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants