Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(UtilService): Move connected component functions #1347

Closed
hirokiterashima opened this issue Jul 19, 2023 · 1 comment · Fixed by #1348
Closed

refactor(UtilService): Move connected component functions #1347

hirokiterashima opened this issue Jul 19, 2023 · 1 comment · Fixed by #1348
Assignees
@hirokiterashima
Labels
Code Quality released
Milestone
Tech Debt 20 -> 19

Comments

@hirokiterashima
Copy link
Member

These functions should be moved to ComponentContent.ts

  • hasImportWorkConnectedComponent()
  • hasShowWorkConnectedComponent()
  • hasXConnectedComponent()

Also, merge them to one function, hasConnectedComponent(), that takes in a connectedComponentType as a second parameter.

hasConnectedComponent(content: ComponentContent, connectedComponentType: 'showWork' | 'importWork') {}
@hirokiterashima hirokiterashima added this to the Tech Debt 20 -> 19 milestone Jul 19, 2023
@hirokiterashima hirokiterashima self-assigned this Jul 19, 2023
hirokiterashima added a commit that referenced this issue Jul 19, 2023
@hirokiterashima
refactor(UtilService): Move connected component functions #1347
70317f7
@hirokiterashima hirokiterashima mentioned this issue Jul 19, 2023
Merged
hirokiterashima added a commit that referenced this issue Jul 20, 2023
@hirokiterashima
refactor(UtilService): Move connected component functions #1347 (#1348)
64baf04
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.106.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality released
Projects
WISE Development
Status: Done
Milestone
Tech Debt 20 -> 19
Development

Successfully merging a pull request may close this issue.

refactor(UtilService): Move connected component functions WISE-Community/WISE-Client
1 participant
@hirokiterashima