Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Authoring): Outside Resource model images extend beyond card #1321

Merged

Conversation

geoffreykwan
Copy link
Member

Changes

Changed margin styling for model card title, image, and actions.

Test

Open the authoring view for an Outside Resource component and make sure the model images do not extend beyond the card. Also make sure the card title and actions have padding so that they are not right up against the edge of the card.

#1320

@geoffreykwan geoffreykwan self-assigned this Jun 28, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review June 28, 2023 00:28
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit 4b63ad7 into develop Jun 28, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the issue-1320-fix-outside-resource-model-image-in-authoring branch June 28, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants