Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button Icons): Alignment is slightly off #1323

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(Button Icons): Alignment is slightly off #1323

merged 1 commit into from
Jun 28, 2023

Conversation

geoffreykwan
Copy link
Member

Changes

Fixed button icon alignment in some places

Test

Make sure the button icon alignment is centered in these locations

  • Side nav in Authoring Tool and Grading Tool
  • Authoring Tool import component choose component and choose location views
  • Grading Tool alert icon

Closes #1322

@geoffreykwan geoffreykwan self-assigned this Jun 28, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review June 28, 2023 01:36
@hirokiterashima hirokiterashima self-requested a review June 28, 2023 15:02
hirokiterashima
hirokiterashima approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit dafa53a into develop Jun 28, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the issue-1322-fix-button-icon-alignment branch June 28, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(Button Icons): Alignment is slightly off
2 participants
@geoffreykwan @hirokiterashima