Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Node Authoring): Reorder components with drag and drop #1345

Merged

Conversation

hirokiterashima
Copy link
Member

Changes

  • Implement reorder components with drag&drop. Only one component can be moved this way at this time.
  • Clean up code

Test

  • Component reorder using drag&drop works as expected

Closes #1342

@hirokiterashima hirokiterashima self-assigned this Jul 18, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review July 18, 2023 00:11
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main drag and drop functionality seems to work well. I noticed two minor issues.

  1. There are now unnecessary scroll bars around the components.

Screenshot 2023-07-20 113134

  1. If there is only one component, the drag handle should not be displayed and the user should not be able to drag the component.

@hirokiterashima
Copy link
Member Author

I removed the drag handle if there is only one component.

@breity can you please take a look at the scrolling issue that @geoffreykwan found? I wasn't sure about the best way to handle it.

- Keep drag handle at top of component
- Reduce spacing between component action icons
#1342
@breity breity requested a review from geoffreykwan July 21, 2023 17:18
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I noticed a minor styling issue.

When there is only one component, there used to be some padding to the left of the component checkbox but now there is none. The component checkbox is a little too close to the border now. I think we should add the padding back when there is only one component.

Before

Screenshot 2023-07-24 155711

Now

Screenshot 2023-07-24 155735

@hirokiterashima hirokiterashima merged commit e974f06 into develop Jul 25, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the issue-1342-node-authoring-reoder-components-drag-drop branch July 25, 2023 00:32
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.106.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(Node Authoring): Reorder components with drag and drop
3 participants