-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Node Authoring): Reorder components with drag and drop #1345
feat(Node Authoring): Reorder components with drag and drop #1345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the drag handle if there is only one component. @breity can you please take a look at the scrolling issue that @geoffreykwan found? I wasn't sure about the best way to handle it. |
- Keep drag handle at top of component - Reduce spacing between component action icons #1342
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I noticed a minor styling issue.
When there is only one component, there used to be some padding to the left of the component checkbox but now there is none. The component checkbox is a little too close to the border now. I think we should add the padding back when there is only one component.
Before
Now
🎉 This PR is included in version 5.106.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
Test
Closes #1342