chore(Authoring): Convert WISE link authoring to Angular #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirokiterashima
approved these changes
Jul 26, 2023
Comment on lines
11
to
15
| items: any[]; | ||
| wiseLinkComponentId: string = ''; | ||
| wiseLinkNodeId: string = ''; | ||
| wiseLinkText: string = ''; | ||
| wiseLinkType: string = 'link'; |
There was a problem hiding this comment.
Add private/protected modifiers?
| return this.projectService.getComponents(nodeId); | ||
| } | ||
|
|
||
| protected createWISELink(): void { |
There was a problem hiding this comment.
The name create() is sufficient?
| } | ||
| } | ||
|
|
||
| protected cancelWISELinkAuthoring(): void { |
There was a problem hiding this comment.
The name cancel() is sufficient?
Add variable modifiers, remove unused dependency, and change function names. #1360
|
🎉 This PR is included in version 5.107.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Converted WISELinkAuthoringController to Angular.
Test
Make sure the WISE link authoring works in the HTML component.
Closes #1360