chore(Authoring): Convert project authoring to Angular #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirokiterashima
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Functionality seems to work as before. I have some comments:
- import-step/choose-location page (used when choosing the location for an imported step, automated assessment or interactive simulation) seems to have lost the indentation for the steps?
-
Add private/protected modifiers for ProjectAuthoringComponent class variables?
-
See inline comments
Comment on lines
62
to
68
| private ConfigService: ConfigService, | ||
| private CopyNodesService: CopyNodesService, | ||
| private DeleteNodeService: DeleteNodeService, | ||
| private MoveNodesService: MoveNodesService, | ||
| private ProjectService: TeacherProjectService, | ||
| private TeacherDataService: TeacherDataService | ||
| ) { | ||
| this.$translate = $filter('translate'); | ||
| } | ||
|
|
||
| $onInit() { | ||
| this.items = this.ProjectService.idToOrder; | ||
| private TeacherDataService: TeacherDataService, | ||
| private upgrade: UpgradeModule |
There was a problem hiding this comment.
Lower case variable names, change TeacherDataServicer to dataService?
|
🎉 This PR is included in version 5.107.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Converted project authoring to Angular.
Test
Make sure everything in the project authoring still works including but not limited to
Closes #1366