Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Node Authoring): Single component is draggable #1375

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

breity
Copy link
Member

@breity breity commented Jul 31, 2023

Changes

Disables dragging on components in node authoring view when there is only one component in the step.

Resolves #1374.

Test

  • Make sure dragging components is disabled when there is only one component in the step.
  • Make sure dragging to reorder components still works when there is more than one component.

@breity breity self-assigned this Jul 31, 2023
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breity breity merged commit 79831db into develop Jul 31, 2023
1 of 2 checks passed
@breity breity deleted the issue-1374-single-component-is-draggable branch July 31, 2023 21:31
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.107.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hirokiterashima
Copy link
Member

@breity looks like the unit tests started failing due to changes in this PR. Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug(Node Authoring): Single component is draggable
2 participants