Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Classroom Monitor): Update workgroup name on previous/next click #1389

Merged

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Aug 8, 2023

Changes

Update workgroup name when the workgroup changes. It used to always display the same workgroup name even when the workgroup changed.

Test

  1. Load a run in the Classroom Monitor that has multiple workgroups
  2. Go to the "Grade By Team" view
  3. Choose a workgroup
  4. Click the "Next Team" button, the student data will change but the name displayed in the drop down will remain the same
  5. Click the "Previous Team" button, the student data will change but the name displayed in the drop down will remain the same

Closes #1388

@geoffreykwan geoffreykwan self-assigned this Aug 8, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review August 8, 2023 20:28
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

On a side note, feel free to clean up surrounding code if you think it won't increase the review scope and won't get in the way of the review. So in this case, you can lower-case variable names (ConfigService, TeacherDataService), put @Input and customClass on the same line, add private/protected modifiers, etc. We should try to make the code cleaner than we found it if possible.

@geoffreykwan geoffreykwan merged commit f9f3384 into develop Aug 9, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the issue-1388-fix-workgroup-previous-next-displayed-name branch August 9, 2023 16:15
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.107.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug(Classroom Monitor): Workgroup previous and next buttons do not update displayed workgroup name
2 participants