refactor(Project Authoring): Extract move node location selection feature to component

[hirokiterashima]

Notes

• Please style and clean code/template as you see fit

Changes

• Extract mode node location selection feature from ProjectAuthoring to ChooseMoveNodeLocationComponent
• Clean up related code

Test

• Move node works as before:
  • one node at a time
  • multiple nodes at a time
  • steps
  • groups
  • to/from active and inactive sections

Closes #1393

[geoffreykwan]

Functionality works well.

I'm wondering if instead of using ng-templates it would be better to create components. It would simplify the html and the components could be reused in other templates.

This looks like code duplication. It seems like Code Climate doesn't check html files?

WISE-Client/src/assets/wise5/authoringTool/choose-move-node-location/choose-move-node-location.component.html

Lines 118 to 125 in 0497dd7

	<div fxLayout="row" fxLayoutAlign="start center" fxLayoutGap="10px">
	<ng-container
	*ngTemplateOutlet="nodeIconAndTitle; context: { nodeId: inactiveChildId }"
	></ng-container>
	<ng-container
	*ngTemplateOutlet="moveAfterButton; context: { nodeId: inactiveChildId }"
	></ng-container>
	</div>

WISE-Client/src/assets/wise5/authoringTool/choose-move-node-location/choose-move-node-location.component.html

Lines 142 to 149 in 0497dd7

	<div fxLayout="row" fxLayoutAlign="start center" fxLayoutGap="10px">
	<ng-container
	*ngTemplateOutlet="nodeIconAndTitle; context: { nodeId: inactiveNode.id }"
	></ng-container>
	<ng-container
	*ngTemplateOutlet="moveAfterButton; context: { nodeId: inactiveNode.id }"
	></ng-container>
	</div>

[breity]

Looks good. I cleaned up some styles and removed unused classes.

I also updated margin styles to be friendly to RTL languages.

[hirokiterashima]

Thanks @breity. Good to remove unused styles. Template files look cleaner now.

@geoffreykwan can you take a final look?

[geoffreykwan]

When you move a step or a lesson and are in the view to choose the location, the unused lessons and unused steps are not indented correctly.

[hirokiterashima]

Fixed. PTAL.

[geoffreykwan]

Looks good.

[hirokiterashima]

🎉 This PR is included in version 5.108.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀