Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ProjectAuthoringComponent): Code cleanup #1408

Merged
merged 3 commits into from
Sep 8, 2023
Merged

refactor(ProjectAuthoringComponent): Code cleanup #1408

merged 3 commits into from
Sep 8, 2023

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Sep 7, 2023 •
edited
Loading

Changes

  • Remove unused function getSelectedItemTypes()
  • Extract duplicate code (in ProjectAuthoringComponent and WISELinkAuthoringDialogComponent) to TeacherProjectService.getNodesInOrder()
  • Remove unnecessary null checks in inactiveNodes
  • Use ternary statement and HOF to improve code readability

Test

  • Project Authoring, esp. features that use the modified code
  • WISELink authoring

@hirokiterashima
Extract duplicate code to setItems()
291eee9 
Remove unused getSelectedItemTypes()
@hirokiterashima
Remove unnecessary null checks
3301e9c 
Use ternary statement and HOF to improve readability
@hirokiterashima hirokiterashima self-assigned this Sep 7, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review September 8, 2023 00:17
@hirokiterashima hirokiterashima added this to the Tech Debt 20 -> 19 milestone Sep 8, 2023
geoffreykwan
geoffreykwan approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 21d0fc6 into develop Sep 8, 2023
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-project-authoring-component branch September 8, 2023 20:33
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.110.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
released
Projects
WISE Development
Status: Done
Milestone
Tech Debt 20 -> 19
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan