Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Register User): Extract RegisterUserCompleteComponent #1422

Merged
merged 1 commit into from
Sep 19, 2023
Merged

refactor(Register User): Extract RegisterUserCompleteComponent #1422

merged 1 commit into from
Sep 19, 2023

Conversation

hirokiterashima
Copy link
Member

Changes

  • Extract common code in Register[Student/Teacher]CompleteComponent to abstract RegisterUserCompleteComponent

Test

  • Register student/teacher complete pages work as before
    • "Sign In to Get Started" button takes you to the sign in page
    • Try registering account using Google also

@hirokiterashima hirokiterashima added this to the Tech Debt 20 -> 19 milestone Sep 18, 2023
@hirokiterashima hirokiterashima self-assigned this Sep 18, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review September 18, 2023 15:25
breity
breity approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@hirokiterashima hirokiterashima merged commit cdb7a56 into develop Sep 19, 2023
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-extract-register-user-complete-component branch September 19, 2023 16:50
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.114.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality released
Projects
WISE Development
Status: Done
Milestone
Tech Debt 20 -> 19
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @breity