Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(EditProfileComponent): reduce duplication #1432

Merged
merged 2 commits into from
Sep 28, 2023
Merged

refactor(EditProfileComponent): reduce duplication #1432

merged 2 commits into from
Sep 28, 2023

Conversation

breity
Copy link
Member

@breity breity commented Sep 25, 2023

Changes

  • Extract EditProfileComponent.handleUpdateProfileResponse() and EditProfileComponent.unlinkGoogleAccount() from teacher and student components to parent EditProfileComponent. Rename student and teacher EditProfileComponent to StudentEditProfileComponent and TeacherEditProfileComponent.
  • Extract schoolLevels from TeacherEditProfileComponent and RegisterTeacherFormComponent to global constant.

Test

  • Make sure editing student and teacher profiles work as before and toast message is shown when profile is updated.
  • Make sure clicking Unlink Google Account button opens the unlink Google account dialog.

@breity breity self-assigned this Sep 25, 2023
geoffreykwan
geoffreykwan approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@breity breity added this to the Tech Debt 20 -> 19 milestone Sep 28, 2023
@breity breity merged commit 892483b into develop Sep 28, 2023
4 of 5 checks passed
@breity breity deleted the refactor-edit-profile-components-reduce-duplication branch September 28, 2023 16:25
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.114.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@breity breity

Labels
Code Quality released
Projects
WISE Development
Status: Done
Milestone
Tech Debt 20 -> 19
Development

Successfully merging this pull request may close these issues.
3 participants
@breity @hirokiterashima @geoffreykwan