Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(TeacherProjectService): Move lock node functions to NavItemComponent #1922

Merged
merged 1 commit into from
Aug 29, 2024
Merged

refactor(TeacherProjectService): Move lock node functions to NavItemComponent #1922

merged 1 commit into from
Aug 29, 2024

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 27, 2024 •
edited
Loading

Changes

  • Move functions related to locking lessons in the CM to NavItemComponent
    • addTeacherRemovalConstraint()
    • removeTeacherRemovalConstraint()
  • Clean up code. These functions became private functions in NavItemComponent
  • Update tests

Test

  • Locking/unlocking lessons in the CM for specific period and for all periods works as before
    • Should show the lock/unlock icon in the CM
    • Should lock/unlock lesson for the students

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 27, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 27, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 27, 2024 16:25
breity
breity approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hirokiterashima hirokiterashima merged commit 6b1b0d5 into develop Aug 29, 2024
3 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-TeacherProjectService-moveLockNode-functions branch August 29, 2024 22:29
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.156.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality released
Projects
WISE Development 2023-2024
Status: Done
Milestone
Tech Debt 18 -> 17
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @breity