Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ChooseBranchPathDialogComponent): Convert to standalone #1952

Merged
merged 1 commit into from
Sep 21, 2024
Merged

refactor(ChooseBranchPathDialogComponent): Convert to standalone #1952

merged 1 commit into from
Sep 21, 2024

Conversation

hirokiterashima
Copy link
Member

Changes

  • Convert to ChooseBranchPathDialogComponent standalone
  • Make VLEComponent import ChooseBranchPathDialogComponent instead of StudentVLEModule. We're trying to remove the latter.

Test

  • In VLE Preview of a unit with a branch, the "Choose branch path" dialog appears and works as before

@hirokiterashima hirokiterashima self-assigned this Sep 20, 2024
@hirokiterashima hirokiterashima added this to the Standalone Components milestone Sep 20, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review September 21, 2024 00:00
@hirokiterashima hirokiterashima merged commit 022da86 into develop Sep 21, 2024
5 checks passed
@hirokiterashima hirokiterashima deleted the convert-ChooseBranchPathDialogComponent-to-standalone branch September 21, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality
Projects
WISE Development 2023-2024
Status: Done
Milestone
Standalone Components
Development

Successfully merging this pull request may close these issues.
1 participant
@hirokiterashima