Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification metadata #1503

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Mar 20, 2024

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walletconnect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 9:17pm

body: string
id: string
// A call-to-action URL for when clicking on the notification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really control the UX of how they use the URL though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess I was overly prescriptive. But I wanted to explain what it was intended for more than just "a URL". Do you have a suggestion for better description?

Copy link
Contributor

@glitch-txs glitch-txs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge this? @chris13524 @devceline

@chris13524
Copy link
Member Author

can we merge this?

@glitch-txs no because Web3Inbox client doesn't yet support: https://linear.app/walletconnect/issue/W3I-80/custom-notification-metadata-%5Bclient%5D

Copy link
Contributor

@glitch-txs glitch-txs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure changed under AppKit/WalletKit

@chris13524 chris13524 marked this pull request as draft July 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants