Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch chain #2899

Merged
merged 4 commits into from
Jun 30, 2023
Merged

fix: switch chain #2899

merged 4 commits into from
Jun 30, 2023

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jun 30, 2023

Description

Fixed a possible issue when attempting to send wallet_switchEthereumChain might be blocked by SDK validation for approved chains

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests
dogfooding canary - 2.8.7-canary.0

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

Gancho Radkov added 2 commits June 30, 2023 12:01
…ed by validation due to specifying request chain that's not approved
@ganchoradkov ganchoradkov self-assigned this Jun 30, 2023
@ganchoradkov ganchoradkov added the type: bug Something isn't working label Jun 30, 2023
@arein arein added the accepted label Jun 30, 2023
@ganchoradkov ganchoradkov merged commit b4fb877 into v2.0 Jun 30, 2023
8 of 9 checks passed
@ganchoradkov ganchoradkov deleted the fix/switch-chain branch June 30, 2023 09:20
@siosio34
Copy link
Contributor

siosio34 commented Jul 4, 2023

@ganchoradkov @bkrem

hello
Thank you for the nice pull request.

Currently, if you connect Metamask through Wallet Connect, the chain conversion does not work well, so I am watching the pull request very interestingly.

I have three questions.

  1. I am using the Ethereum-provider package. Is that package also being modified?

  2. Since the release is still 2.8.6, it seems that the code has not been reflected yet. Can we expect the code content to be reflected in 2.8.7?

  3. If this code is reflected, will it be possible to freely switch chains when connected through Wallet Connect in Metamask Mobile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants