-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch call status via bundler url #5171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some minor suggestions.
case "wallet_getCallsStatus": | ||
return (await this.getCallStatus(args)) as unknown as T; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this result in a unhandled promise rejection if the call throws ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it as http calls are try/catched. Only if the request can't be sent to thte wallet and/or is rejected by the wallet it would throw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how was this tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work with strict content-security-policies where arbitrary Bundler URLs cannot be called. That's why we need the Wallet Service. I'd expect some mention around these problems somewhere
…^2.16.2 (#6064) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/react-native-compat](https://redirect.github.com/walletconnect/walletconnect-monorepo) | [`^2.16.1` -> `^2.16.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/react-native-compat)</summary> ### [`v2.16.2`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.16.2) [Compare Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.16.1...2.16.2) #### What's Changed - feat: init event by [@​ganchoradkov](https://redirect.github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5343](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5343) - feat: fetch call status via bundler url by [@​ganchoradkov](https://redirect.github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5171](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5171) - fix: sets domain if available else sets `sp` by [@​ganchoradkov](https://redirect.github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5370](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5370) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.16.1...2.16.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/utils](https://redirect.github.com/walletconnect/walletconnect-monorepo) | [`^2.16.1` -> `^2.16.2`](https://renovatebot.com/diffs/npm/@walletconnect%2futils/2.16.1/2.16.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2futils/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2futils/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2futils/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2futils/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/utils)</summary> ### [`v2.16.2`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.16.2) [Compare Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.16.1...2.16.2) ##### What's Changed - feat: init event by [@​ganchoradkov](https://redirect.github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5343](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5343) - feat: fetch call status via bundler url by [@​ganchoradkov](https://redirect.github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5171](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5171) - fix: sets domain if available else sets `sp` by [@​ganchoradkov](https://redirect.github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5370](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5370) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.16.1...2.16.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>
Description
Implemented functionality in
universal-provider
where if bundler name is provided, it will do a http call to get the status instead of sending the request to the wallet. If bundler name is not provided then the request is sent to the walletbased on #4649
Type of change
How has this been tested?
tests
Checklist