Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: events sdk #5188

Merged
merged 15 commits into from
Aug 26, 2024
Merged

feat: events sdk #5188

merged 15 commits into from
Aug 26, 2024
+891 −34

Conversation

ganchoradkov
Copy link
Member

Description

Implemented Events according to spec

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

dogfooding, tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Jul 16, 2024
@ganchoradkov ganchoradkov marked this pull request as ready for review July 16, 2024 11:36
chris13524
chris13524 reviewed Jul 16, 2024
View reviewed changes
packages/core/src/controllers/events.ts Outdated
if (eventsToSend.length === 0) return;

try {
const response = await fetch(EVENTS_CLIENT_API_URL, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

priority should be set to low

Cali93
Cali93 reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the results that will come out of this.
Left some comments, good job so far 💪

packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/events.ts Show resolved Hide resolved
packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/events.ts Show resolved Hide resolved
packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/pairing.ts Outdated Show resolved Hide resolved
packages/sign-client/src/controllers/engine.ts Show resolved Hide resolved
chris13524
chris13524 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganchoradkov ganchoradkov merged commit 32d61fe into v2.0 Aug 26, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the feat/events-sdk branch August 26, 2024 11:29
@ganchoradkov ganchoradkov mentioned this pull request Aug 30, 2024
Merged
20 tasks
github-merge-queue bot referenced this pull request in valora-inc/wallet Aug 31, 2024
@renovate
chore(deps): update dependency @walletconnect/react-native-compat to …
9da95fc 
…^2.15.2 (#5871)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://github.com/walletconnect/walletconnect-monorepo)
| [`^2.15.1` ->
`^2.15.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.15.2`](https://github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.2)

[Compare
Source](https://github.com/walletconnect/walletconnect-monorepo/compare/2.15.1...2.15.2)

##### What's Changed

- chore: prep for 2.15.1 release by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5287](https://github.com/WalletConnect/walletconnect-monorepo/pull/5287)
- feat: events sdk by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5188](https://github.com/WalletConnect/walletconnect-monorepo/pull/5188)
- chore: sets `trace` level logging on canary by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5292](https://github.com/WalletConnect/walletconnect-monorepo/pull/5292)
- fix: Verify V3 by
[@&#8203;chris13524](https://github.com/chris13524) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5285](https://github.com/WalletConnect/walletconnect-monorepo/pull/5285)
- Revert "chore: reverts verify v2" by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5288](https://github.com/WalletConnect/walletconnect-monorepo/pull/5288)
- fix(deps): update dependency elliptic to v6.5.7 \[security] by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5275](https://github.com/WalletConnect/walletconnect-monorepo/pull/5275)
- chore: doesn't init verify api in dev mode by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5309](https://github.com/WalletConnect/walletconnect-monorepo/pull/5309)
- fix: reconnection loop by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5315](https://github.com/WalletConnect/walletconnect-monorepo/pull/5315)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.15.1...2.15.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot referenced this pull request in valora-inc/wallet Sep 1, 2024
@renovate
chore(deps): update dependency @walletconnect/react-native-compat to …
960f9b7 
…^2.15.2 (#5871)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://github.com/walletconnect/walletconnect-monorepo)
| [`^2.15.1` ->
`^2.15.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.15.2`](https://github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.2)

[Compare
Source](https://github.com/walletconnect/walletconnect-monorepo/compare/2.15.1...2.15.2)

##### What's Changed

- chore: prep for 2.15.1 release by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5287](https://github.com/WalletConnect/walletconnect-monorepo/pull/5287)
- feat: events sdk by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5188](https://github.com/WalletConnect/walletconnect-monorepo/pull/5188)
- chore: sets `trace` level logging on canary by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5292](https://github.com/WalletConnect/walletconnect-monorepo/pull/5292)
- fix: Verify V3 by
[@&#8203;chris13524](https://github.com/chris13524) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5285](https://github.com/WalletConnect/walletconnect-monorepo/pull/5285)
- Revert "chore: reverts verify v2" by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5288](https://github.com/WalletConnect/walletconnect-monorepo/pull/5288)
- fix(deps): update dependency elliptic to v6.5.7 \[security] by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5275](https://github.com/WalletConnect/walletconnect-monorepo/pull/5275)
- chore: doesn't init verify api in dev mode by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5309](https://github.com/WalletConnect/walletconnect-monorepo/pull/5309)
- fix: reconnection loop by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5315](https://github.com/WalletConnect/walletconnect-monorepo/pull/5315)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.15.1...2.15.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@lukaisailovic lukaisailovic Awaiting requested review from lukaisailovic

@Cali93 Cali93 Awaiting requested review from Cali93

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganchoradkov @chris13524 @Cali93 @arein