-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removes session approval peer acknowledgment delay #5197
Merged
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganchoradkov
changed the title
refactor: removes session approval peer acknowledgment ack
refactor: removes session approval peer acknowledgment delay
Jul 18, 2024
Cali93
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏎️
20 tasks
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Aug 20, 2024
…^2.15.0 (#5795) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/react-native-compat](https://github.com/walletconnect/walletconnect-monorepo) | [`^2.14.0` -> `^2.15.0`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.14.0/2.15.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.14.0/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.14.0/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/react-native-compat)</summary> ### [`v2.15.0`](https://github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.0) [Compare Source](https://github.com/walletconnect/walletconnect-monorepo/compare/2.14.0...2.15.0) #### What's Changed - chore: prep for `2.14.0` release by [@​ganchoradkov](https://github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5195](https://github.com/WalletConnect/walletconnect-monorepo/pull/5195) - refactor: removes session approval peer acknowledgment delay by [@​ganchoradkov](https://github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5197](https://github.com/WalletConnect/walletconnect-monorepo/pull/5197) - chore(deps): update docker/build-push-action action to v6 by [@​renovate](https://github.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4641](https://github.com/WalletConnect/walletconnect-monorepo/pull/4641) - chore(deps): update actions/add-to-project action to v1.0.2 by [@​renovate](https://github.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5101](https://github.com/WalletConnect/walletconnect-monorepo/pull/5101) - chore: fix some comments by [@​renshuncui](https://github.com/renshuncui) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4640](https://github.com/WalletConnect/walletconnect-monorepo/pull/4640) - AlgorandProvider [#​877](https://github.com/walletconnect/walletconnect-monorepo/issues/877) [#​2760](https://github.com/walletconnect/walletconnect-monorepo/issues/2760) by [@​scholtz](https://github.com/scholtz) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5201](https://github.com/WalletConnect/walletconnect-monorepo/pull/5201) - chore: fix typo by [@​riyueguang](https://github.com/riyueguang) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5216](https://github.com/WalletConnect/walletconnect-monorepo/pull/5216) - chore: change handshake canary to only measure 1 client initialization by [@​chris13524](https://github.com/chris13524) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5250](https://github.com/WalletConnect/walletconnect-monorepo/pull/5250) - refactor: session settle response by [@​ganchoradkov](https://github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5259](https://github.com/WalletConnect/walletconnect-monorepo/pull/5259) - refactor: publishes session settle request before the session propose… by [@​ganchoradkov](https://github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5246](https://github.com/WalletConnect/walletconnect-monorepo/pull/5246) - feat: verify v2 by [@​ganchoradkov](https://github.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5236](https://github.com/WalletConnect/walletconnect-monorepo/pull/5236) - chore: partially dedupe fetch implementations and use native fetch instead by [@​talentlessguy](https://github.com/talentlessguy) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5112](https://github.com/WalletConnect/walletconnect-monorepo/pull/5112) #### New Contributors - [@​renshuncui](https://github.com/renshuncui) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4640](https://github.com/WalletConnect/walletconnect-monorepo/pull/4640) - [@​scholtz](https://github.com/scholtz) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5201](https://github.com/WalletConnect/walletconnect-monorepo/pull/5201) - [@​riyueguang](https://github.com/riyueguang) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5216](https://github.com/WalletConnect/walletconnect-monorepo/pull/5216) - [@​talentlessguy](https://github.com/talentlessguy) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/5112](https://github.com/WalletConnect/walletconnect-monorepo/pull/5112) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.14.0...2.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed legacy peer acknowledgment delay during session approval
Type of change
How has this been tested?
n/a
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.