Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Verify V3 #5285

Merged
merged 8 commits into from
Aug 27, 2024
Merged

fix: Verify V3 #5285

merged 8 commits into from
Aug 27, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Aug 19, 2024 •
edited
Loading

Description

Upgrades the Verify attestation style as per the v3 spec.

Remaining work:

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Existing automated tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chris13524 chris13524 self-assigned this Aug 19, 2024
@arein arein added the accepted label Aug 19, 2024
ganchoradkov
ganchoradkov approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

chris13524
chris13524 commented Aug 23, 2024
View reviewed changes
packages/sign-client/src/controllers/engine.ts
Comment on lines 1478 to +1480
attestationId: attestation,
hash: hashMessage(JSON.stringify(payload)),
encryptedId,
Copy link
Member Author

@chris13524 chris13524 Aug 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganchoradkov isn't one of these (attestationId, hash, encryptedId) redundant with the other?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope because

  • attestationId = the jwt
  • hash = the unecnrypted payload used for verify v1
  • encryptedId = hash of the encrypted message used for verify v2

encryptedId is used for the check against jwt.payload.id

@chris13524 chris13524 changed the base branch from v2.0 to revert-5286-chore/revert-verify-v2 August 23, 2024 21:40
@ganchoradkov ganchoradkov merged commit dd255e8 into revert-5286-chore/revert-verify-v2 Aug 27, 2024
@ganchoradkov ganchoradkov deleted the fix/verify-v3 branch August 27, 2024 07:03
@ganchoradkov ganchoradkov mentioned this pull request Aug 30, 2024
Merged
20 tasks
github-merge-queue bot referenced this pull request in valora-inc/wallet Aug 31, 2024
@renovate
chore(deps): update dependency @walletconnect/react-native-compat to …
9da95fc 
…^2.15.2 (#5871)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://github.com/walletconnect/walletconnect-monorepo)
| [`^2.15.1` ->
`^2.15.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.15.2`](https://github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.2)

[Compare
Source](https://github.com/walletconnect/walletconnect-monorepo/compare/2.15.1...2.15.2)

##### What's Changed

- chore: prep for 2.15.1 release by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5287](https://github.com/WalletConnect/walletconnect-monorepo/pull/5287)
- feat: events sdk by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5188](https://github.com/WalletConnect/walletconnect-monorepo/pull/5188)
- chore: sets `trace` level logging on canary by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5292](https://github.com/WalletConnect/walletconnect-monorepo/pull/5292)
- fix: Verify V3 by
[@&#8203;chris13524](https://github.com/chris13524) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5285](https://github.com/WalletConnect/walletconnect-monorepo/pull/5285)
- Revert "chore: reverts verify v2" by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5288](https://github.com/WalletConnect/walletconnect-monorepo/pull/5288)
- fix(deps): update dependency elliptic to v6.5.7 \[security] by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5275](https://github.com/WalletConnect/walletconnect-monorepo/pull/5275)
- chore: doesn't init verify api in dev mode by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5309](https://github.com/WalletConnect/walletconnect-monorepo/pull/5309)
- fix: reconnection loop by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5315](https://github.com/WalletConnect/walletconnect-monorepo/pull/5315)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.15.1...2.15.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot referenced this pull request in valora-inc/wallet Sep 1, 2024
@renovate
chore(deps): update dependency @walletconnect/react-native-compat to …
960f9b7 
…^2.15.2 (#5871)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://github.com/walletconnect/walletconnect-monorepo)
| [`^2.15.1` ->
`^2.15.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.15.2`](https://github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.2)

[Compare
Source](https://github.com/walletconnect/walletconnect-monorepo/compare/2.15.1...2.15.2)

##### What's Changed

- chore: prep for 2.15.1 release by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5287](https://github.com/WalletConnect/walletconnect-monorepo/pull/5287)
- feat: events sdk by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5188](https://github.com/WalletConnect/walletconnect-monorepo/pull/5188)
- chore: sets `trace` level logging on canary by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5292](https://github.com/WalletConnect/walletconnect-monorepo/pull/5292)
- fix: Verify V3 by
[@&#8203;chris13524](https://github.com/chris13524) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5285](https://github.com/WalletConnect/walletconnect-monorepo/pull/5285)
- Revert "chore: reverts verify v2" by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5288](https://github.com/WalletConnect/walletconnect-monorepo/pull/5288)
- fix(deps): update dependency elliptic to v6.5.7 \[security] by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5275](https://github.com/WalletConnect/walletconnect-monorepo/pull/5275)
- chore: doesn't init verify api in dev mode by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5309](https://github.com/WalletConnect/walletconnect-monorepo/pull/5309)
- fix: reconnection loop by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5315](https://github.com/WalletConnect/walletconnect-monorepo/pull/5315)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.15.1...2.15.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganchoradkov ganchoradkov ganchoradkov approved these changes

Assignees

@chris13524 chris13524

Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris13524 @ganchoradkov @arein