Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subscribe timeout rejection #5427

Merged
merged 4 commits into from
Oct 8, 2024
Merged

fix: subscribe timeout rejection #5427

merged 4 commits into from
Oct 8, 2024
+64 −18

Conversation

ganchoradkov
Copy link
Member

Description

fixed a bug where rpcSubscribe didn't throw when subscriber timeout was reached
Context: https://walletconnect.slack.com/archives/C06HXQ9K32T/p1728086800794779

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Oct 8, 2024
Cali93
Cali93 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, but LGTM if that's resolved

packages/core/src/controllers/relayer.ts Show resolved Hide resolved
@ganchoradkov ganchoradkov merged commit dcaeede into v2.0 Oct 8, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the fix/subscribe-timeout branch October 8, 2024 15:05
@ganchoradkov ganchoradkov mentioned this pull request Oct 9, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignaciosantise ignaciosantise ignaciosantise approved these changes

@Cali93 Cali93 Cali93 approved these changes

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganchoradkov @ignaciosantise @Cali93 @arein