fix: add sequence number of subscriptions revision #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
devceline
approved these changes
Jan 2, 2024
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #185
Problem
There is a race condition if multiple subscription updates happen at the same time that a client will receive them out-of-order and display an outdated version.
Solution
Notify Server will now store a version for the subscriptions list. I.e. everytime a subscription is updated (in a way that would trigger subscriptions changed e.g. a subscribe, update, or delete), then this sequence number will also be incremented.
The sequence number is sent to the account alongside the list of subscriptions which clients will then store with their local list of subscriptions. Whenever the client processes an incoming
sbsvalue it must first check the sequence number, and if it is smaller than the current number then it must disregard the update.