📩 Store comment draft in local storage per submission #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ClumsyVlad and the rest of your teammates on |
Merged
ClumsyVlad
force-pushed
the
add-debounce-hook
branch
from
2f54c10
to
5c8d6de
Compare
ClumsyVlad
force-pushed
the
save-comment-state-in-local-sotrage
branch
2 times, most recently
from
48b142f
to
ffedbff
Compare
nezouse
reviewed
May 8, 2024
src/lib/localStorage.ts
Outdated
| @@ -3,6 +3,7 @@ import { z } from "zod"; | |||
| export const LOCAL_STORAGE_KEYS = { | |||
| waveStepsData: "waveStepsData", | |||
| applicationStepsData: "applicationStepsData", | |||
| commentsData: "commentsData", | |||
There was a problem hiding this comment.
It needs at least application id
There was a problem hiding this comment.
Sure, but not in this array I believe 🤔
ClumsyVlad
force-pushed
the
add-debounce-hook
branch
from
a4f9cc2
to
d9cb2d9
Compare
ClumsyVlad
force-pushed
the
save-comment-state-in-local-sotrage
branch
from
ffedbff
to
1b27d2e
Compare
ClumsyVlad
changed the title
nezouse
reviewed
May 9, 2024
src/lib/localStorage.ts
Outdated
| @@ -3,9 +3,10 @@ import { z } from "zod"; | |||
| export const LOCAL_STORAGE_KEYS = { | |||
| waveStepsData: "waveStepsData", | |||
| applicationStepsData: "applicationStepsData", | |||
| commentData: "commentData", | |||
There was a problem hiding this comment.
Suggested change
| commentData: "commentData", | |
| commentData: (applicationId) => `commentData-${applicationId}`, |
There was a problem hiding this comment.
Not sure how types in getLocalStorageValue should work then 🤔
ClumsyVlad
force-pushed
the
add-debounce-hook
branch
from
d9cb2d9
to
1b2346d
Compare
ClumsyVlad
force-pushed
the
save-comment-state-in-local-sotrage
branch
from
1b27d2e
to
3e03fde
Compare
nezouse
force-pushed
the
save-comment-state-in-local-sotrage
branch
from
c4ac13e
to
56a396d
Compare
|
▲ Vercel deployment successful! Preview Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.