[feat] added cloudflare static tunnels support #282
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "ingress": [ | ||
| { | ||
| "hostname": `robo.${process.env.CLOUDFLARE_DOMAIN}`, | ||
| "service": "http://localhost:3000" |
There was a problem hiding this comment.
Local service port should be process.env.PORT by default if that exists.
There was a problem hiding this comment.
Fixed. Port will default to 3000 if none is set in the .env file
| cloudflareLogger.debug(`Updated .env file with ${key}=${value}`) | ||
| } | ||
|
|
||
| function installService(token: string) { |
There was a problem hiding this comment.
Do we really want to install cloudflared as a service on the user machine even though startCloudflared already runs the tunnel associated with that token?
| export function startCloudflared(url: string) { | ||
| const tunnelId = process.env.CLOUDFLARE_TUNNEL_ID; | ||
| const tunnelToken = process.env.CLOUDFLARE_TUNNEL_TOKEN; |
There was a problem hiding this comment.
Can we reduce the number of items requested from the user by requesting the tunnel token from Cloudflare ourselves?
There was a problem hiding this comment.
Currently only the Account ID, API Key, and the domain are requested from the user. The tunnel ID and token are stored in the .env file after the initial tunnel creation for later use.
| const tunnelToken = process.env.CLOUDFLARE_TUNNEL_TOKEN; | ||
| const tunnelDomain = process.env.CLOUDFLARE_DOMAIN; | ||
|
|
||
| const commandArgs = (tunnelId && tunnelToken && tunnelDomain) ? ['tunnel', '--no-autoupdate', 'run', '--token', tunnelToken, '--url', url, tunnelId] : ['tunnel', '--url', url, '--no-autoupdate']; |
There was a problem hiding this comment.
This ternary operation is a bit tough to read quickly. Mind cleaning it by appending the token conditionally instead? The code overall would be longer but more legible.
There was a problem hiding this comment.
Refactored for easier readability
|
|
||
| try { | ||
| if (process.env.CLOUDFLARE_TUNNEL_ID) { | ||
| const roboTunnel = await cloudflareRequest(`/accounts/${process.env.CLOUDFLARE_ACCOUNT_ID}/cfd_tunnel/${process.env.CLOUDFLARE_TUNNEL_ID}/token`); |
There was a problem hiding this comment.
Do Cloudflare's tunnel tokens expire at some point? If so, do we have a way to auto refresh them?
There was a problem hiding this comment.
I was unable to find any documentation that would hint that they expire or any endpoints that let us refresh them.
This pertains to #276