Go back to return by value

Revert "Fix definition of to_path"

This reverts commit e5c08bb.

Revert "try making to_path return a c str to make mingw happy"

This reverts commit f16137b.

src/support/path.cpp

@@ -26,7 +26,7 @@
 namespace wasm::Path {
 
 #ifdef _WIN32
-const PathString::value_type* to_path(const std::string& s) { return string_to_wstring(s); }
+PathString to_path(const std::string& s) { return string_to_wstring(s); }
 
 std::wstring string_to_wstring(const std::string& s) {
   const char* inptr = s.data();
@@ -49,7 +49,7 @@ std::string wstring_to_string(const std::wstring& s) {
   return outstr;
 }
 #else
-const PathString::value_type* to_path(const std::string& s) { return s.c_str(); }
+PathString to_path(const std::string& s) { return s; }
 #endif
 
 char getPathSeparator() {

src/support/path.h

@@ -34,7 +34,7 @@ std::string wstring_to_string(const std::wstring& s);
 using PathString = std::string;
 #endif
 
-const PathString::value_type* to_path(const std::string& s);
+PathString to_path(const std::string& s);
 
 char getPathSeparator();
 std::string getDirName(const std::string& path);