-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::filesystem::path instead of string for file paths #5627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good direction to me to do this gradually!
CI errors look a little worrying though in terms of cross-platform support for this API?
Switching to draft, Going to try a couple of things to maybe avoid compatibility issues... |
This looks like a good first step toward supporting unicode paths on windows. Thanks. |
Closing this in favor of #5671 |
No description provided.