PostEmscripten: Preserve __em_js__ exports (and data) in side modules #5780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jun 23, 2023
This works in a similar way to EM_ASM. See #18228. Depends on WebAssembly/binaryen#5780
sbc100
changed the title
sbc100
changed the title
tlively
approved these changes
Jun 23, 2023
|
Added some testing |
kripken
reviewed
Jun 23, 2023
| (export "__start_em_asm" (global $em_asm_start)) | ||
| ;; CHECK: (export "__stop_em_asm" (global $em_asm_stop)) | ||
| (export "__stop_em_asm" (global $em_asm_stop)) | ||
| (export "__start_em_js" (global $em_js_start)) |
There was a problem hiding this comment.
Why is this one not preserved in the output?
There was a problem hiding this comment.
For EM_ASM we use the global start/stop symbols and split the resulting string on NULL.
For EM_JS each string is exported via its own global export e.g. __em_js__foo so we don't need the start/stop symbols.
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jun 24, 2023
This works in a similar way to EM_ASM. See #18228. Depends on WebAssembly/binaryen#5780
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jun 24, 2023
This works in a similar way to EM_ASM. See #18228. Depends on WebAssembly/binaryen#5780
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jun 26, 2023
This works in a similar way to EM_ASM. See #18228. Depends on WebAssembly/binaryen#5780
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jun 26, 2023
This works in a similar way to EM_ASM. See #18228. Depends on WebAssembly/binaryen#5780
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jun 26, 2023
This works in a similar way to EM_ASM. See #18228. Depends on WebAssembly/binaryen#5780
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jun 26, 2023
This works in a similar way to EM_ASM. See #18228. Depends on WebAssembly/binaryen#5780
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.