-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use include syntax for wasi:clocks #50
Conversation
There's an interesting usability question here for how aggressively we want to use My impression is that, just looking at the before/after diff, the before state is more readable. However, I think that might just be superficially due to the name of the world: |
Yeah totally agree that |
in a separate PR I suggested we rename |
Cool, I like |
I've updated the PR to use |
b8af00a
to
adc8bdd
Compare
Rebased |
adc8bdd
to
640820e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
d8f9c01
to
640820e
Compare
This commit uses `include` syntax to simplify the proxy world by hiding the interfaces from wasi:clock package Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
640820e
to
f27d59e
Compare
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. It'd be good to have @pchickey sign off too.
This commit uses
include
syntax to simplify the proxy world by hiding the interfaces from wasi:clock package