Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document per-item versions using @since gates #102

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

yoshuawuyts
Copy link
Member

Depends on WebAssembly/component-model#332 to be merged first. This documents the stability of all items using the @since gate notation, enabling WIT documents to be updated over time without major compatibility hazards.

For an overview of how this would apply to all existing WASI APIs, including the unstable timezone API, see WebAssembly/WASI#604. Thanks!

@badeend
Copy link
Collaborator

badeend commented Jun 14, 2024

Hi @yoshuawuyts . I'm not in the loop on these changes, so I've waited around a bit to see what the other repos (1 2 3 4 5) are doing. They haven't merged it either, so are "we" still waiting on something? Is it blocked by what you presented yesterday?

If not, I'd be happy to smack the Approve button for you 😛

@yoshuawuyts
Copy link
Member Author

Now that WebAssembly/component-model#332 has been merged, you're right that there shouldn't be anything blocking this from moving forward. I'd be thrilled if we could land this!

As a small FYI, I did just update all the PRs also annotating the @use statements. This was based on WebAssembly/wasi-clocks#61 where we realized that versioning imports actually ends up being important, which we uncovered after a few cycles trying to get the new @unstable feature to pass CI.

I don't think that's anything major here, but I figured I should explain what I just pushed right after you asked me whether this should be good to land. With this change in now, I think this should be good to be merged!

@badeend
Copy link
Collaborator

badeend commented Jun 22, 2024

Alright, great! Something to consider for your other PRs is that this also requires the CI pipeline to be updated. See the change to .github/workflows/main.yml I've just made.

@badeend badeend merged commit 061d28f into WebAssembly:main Jun 22, 2024
1 check passed
@yoshuawuyts yoshuawuyts deleted the since-gates branch June 22, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants