fix: getRootNode() bug

WebReflection · Jul 19, 2023 · 6d391c9 · 6d391c9
1 parent e8dc9de
commit 6d391c9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/esm/interface/node.js b/esm/interface/node.js
@@ -187,10 +187,15 @@ export class Node extends EventTarget {
     return this.parentNode;
   }
 
+  /**
+   * Calling it on an element inside a standard web page will return an HTMLDocument object representing the entire page (or <iframe>).
+   * Calling it on an element inside a shadow DOM will return the associated ShadowRoot.
+   * @return {ShadowRoot | HTMLDocument}
+   */
   getRootNode() {
     let root = this;
     while (root.parentNode)
       root = root.parentNode;
-    return root.nodeType === DOCUMENT_NODE ? root.documentElement : root;
+    return root;
   }
 }
diff --git a/test/interface/text.js b/test/interface/text.js
@@ -20,7 +20,7 @@ assert(text.isConnected, false, '!isConnected');
 assert(text.parentElement, null, '!parentElement');
 assert(node.contains(text), false, '!contains');
 node.firstChild.appendChild(text);
-assert(text.getRootNode(), document.documentElement, 'getRootNode as html');
+assert(text.getRootNode(), document, 'getRootNode as document');
 assert(node.contains(text), true, 'contains');
 assert(text.isConnected, true, 'isConnected');
 assert(text.parentElement, node.firstChild, 'parentElement');