Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deep argument to the type of cloneNode() #222

Merged

Conversation

tai2
Copy link
Contributor

@tai2 tai2 commented Oct 7, 2023

Node's cloneNode() should take the deep argument in type definition. Otherwise, other derived classes like Element also cannot take that parameter in TS.

@WebReflection
Copy link
Owner

to be honest, I am not sure this is a TS shenanigan but cloneNode already takes an optional argument ... I'll merge it, let's hope it will stay around ... if it doesn't, I am afraid I need to change the signature in the code, not in its .d.ts definition.

@WebReflection WebReflection merged commit 94434f7 into WebReflection:main Oct 22, 2023
2 checks passed
@WebReflection WebReflection mentioned this pull request Oct 22, 2023
@tai2 tai2 deleted the add-deep-argument-to-clone-node branch October 23, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants