Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update schemas for contracts to prevent collisions #300

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

0xFable
Copy link
Contributor

@0xFable 0xFable commented Mar 28, 2024

Avoids this problem

warning: output filename collision.
The bin target schema in package vault-manager v0.1.0 (vault-manager) has the same output filename as the bin target schema in package epoch-manager v0.1.0 (epoch-manager). Colliding filename is:
The targets should have unique names.
Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see rust-lang/cargo#6313.

Description and Motivation

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Avoids this problem

warning: output filename collision.
The bin target `schema` in package `vault-manager v0.1.0 (vault-manager)` has the same output filename as the bin target `schema` in package `epoch-manager v0.1.0 (epoch-manager)`.
Colliding filename is:
The targets should have unique names.
Consider changing their names to be unique or compiling them separately.
This may become a hard error in the future; see <rust-lang/cargo#6313>.
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (e59999f) to head (796f738).
Report is 1 commits behind head on release/v2_contracts.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/v2_contracts     #300   +/-   ##
=====================================================
  Coverage                 88.50%   88.50%           
=====================================================
  Files                       252      252           
  Lines                     24029    24029           
=====================================================
  Hits                      21267    21267           
  Misses                     2762     2762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kerber0x kerber0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@0xFable 0xFable merged commit 3ad9825 into release/v2_contracts Apr 4, 2024
4 of 6 checks passed
@0xFable 0xFable deleted the fix/schema_name_collisions branch April 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants