Skip to content

Commit

Permalink
fix: use deflateRaw in pako instead of zlib.es (#869)
Browse files Browse the repository at this point in the history
  • Loading branch information
kumachan-mis committed May 20, 2023
1 parent d6c7a86 commit 09f7a94
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 11 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"prettier": "@willbooster/prettier-config",
"dependencies": {
"jquery": "3.7.0",
"zlib.es": "0.6.0"
"pako": "2.1.0"
},
"devDependencies": {
"@babel/core": "7.21.8",
Expand All @@ -53,6 +53,7 @@
"@types/eslint": "8.37.0",
"@types/jquery": "3.5.16",
"@types/micromatch": "4.0.2",
"@types/pako": "2.0.0",
"@types/sass": "1.43.1",
"@typescript-eslint/eslint-plugin": "5.59.6",
"@typescript-eslint/parser": "5.59.6",
Expand Down
4 changes: 2 additions & 2 deletions src/encoder/plantUmlEncoder.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable unicorn/prefer-code-point */
// fromCharCode is faster than codePointAt and enough for our use case.

import { deflate } from 'zlib.es';
import { deflateRaw } from 'pako';

import { Constants } from '../constants';

Expand All @@ -14,7 +14,7 @@ chrome.runtime.sendMessage({ command: Constants.commands.getPumlServerUrl }, (ur
export const PlantUmlEncoder = {
getImageUrl(pumlContent: string, serverUrl: string = pumlServerUrl): string {
const textEncoder = new TextEncoder();
const encoded = encode64(deflate(textEncoder.encode(pumlContent)));
const encoded = encode64(deflateRaw(textEncoder.encode(pumlContent)));
return `${serverUrl}/svg/${encoded}`;
},
};
Expand Down
24 changes: 16 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2419,6 +2419,13 @@ __metadata:
languageName: node
linkType: hard

"@types/pako@npm:2.0.0":
version: 2.0.0
resolution: "@types/pako@npm:2.0.0"
checksum: 0e79b43daa11dab8d35f7915bd03ce90fe5f2aaa600e9d8297198d0b804aee9edc36cfd5e03d8fedd35b595ef00fa8f81e2b9a69f51b6fa7ec0f312da3d3a304
languageName: node
linkType: hard

"@types/pug@npm:^2.0.6":
version: 2.0.6
resolution: "@types/pug@npm:2.0.6"
Expand Down Expand Up @@ -10061,6 +10068,13 @@ __metadata:
languageName: node
linkType: hard

"pako@npm:2.1.0":
version: 2.1.0
resolution: "pako@npm:2.1.0"
checksum: b355836dead8b796347a6662fbc1bf7fe2dbb101b6d0ca9fcbb5fed6dba13ad3909d0e4f952574d1fdad6409e3c55f0967b97a443b9adc1ab2b441324501fdd1
languageName: node
linkType: hard

"pako@npm:~1.0.2":
version: 1.0.11
resolution: "pako@npm:1.0.11"
Expand Down Expand Up @@ -10307,6 +10321,7 @@ __metadata:
"@types/eslint": "npm:8.37.0"
"@types/jquery": "npm:3.5.16"
"@types/micromatch": "npm:4.0.2"
"@types/pako": "npm:2.0.0"
"@types/sass": "npm:1.43.1"
"@typescript-eslint/eslint-plugin": "npm:5.59.6"
"@typescript-eslint/parser": "npm:5.59.6"
Expand All @@ -10330,6 +10345,7 @@ __metadata:
jquery: "npm:3.7.0"
lint-staged: "npm:13.2.2"
micromatch: "npm:4.0.5"
pako: "npm:2.1.0"
pinst: "npm:3.0.0"
prettier: "npm:2.8.8"
prettier-plugin-svelte: "npm:2.10.0"
Expand All @@ -10345,7 +10361,6 @@ __metadata:
svelte-check: "npm:3.3.2"
svelte-preprocess: "npm:5.0.3"
typescript: "npm:5.0.4"
zlib.es: "npm:0.6.0"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -13548,10 +13563,3 @@ __metadata:
checksum: 1d32379d2bf1475e71c3c6b62ebd2c407938075d597b39835458958cfeb6ed459126581abeaa1a991a6d497968f9b58202272e74eb9d813c8c900b372ee93739
languageName: node
linkType: hard

"zlib.es@npm:0.6.0":
version: 0.6.0
resolution: "zlib.es@npm:0.6.0"
checksum: 95d99b12697fe322aef42c6cc06f54a2dc6d5da3a5701b09682f856fada8926b14f55256f802baa4c9a42d85cf5d9a2630fcfc75c6b111d5b96e0b615cc8380e
languageName: node
linkType: hard

0 comments on commit 09f7a94

Please sign in to comment.