Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency to base64 gem #62

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Jan 29, 2024

because base64 is bundled gem since Ruby 3.4.0dev.

ruby/ruby#9550
https://bugs.ruby-lang.org/issues/20187

Here is the LoadError to use rubyntlm using Ruby 3.4.0dev.
https://github.com/yahonda/httpclient/actions/runs/7695505773/job/20968523567#step:4:13

/home/runner/work/httpclient/httpclient/vendor/bundle/ruby/3.4.0+0/gems/rubyntlm-0.6.3/lib/net/ntlm.rb:39: warning: base64 was loaded from the standard library, but is not part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.
/home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundled_gems.rb:74:in `require': cannot load such file -- base64 (LoadError)

because `base64` is bundled gem since Ruby 3.4.0dev.

ruby/ruby#9550
https://bugs.ruby-lang.org/issues/20187
@pcai pcai merged commit fe81e67 into WinRb:master Jun 6, 2024
@pcai
Copy link
Contributor

pcai commented Jun 6, 2024

@yahonda thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants