Support builds for Electron v32 #1226
Merged
+3,221
−3,207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoshuaWise if you could review this that would be great. |
JoshuaWise
approved these changes
Jul 29, 2024
nikwen
reviewed
Aug 2, 2024
| @@ -1,2165 +1,2165 @@ | |||
| // better_sqlite3.cpp | |||
There was a problem hiding this comment.
What's causing every line in this file to change? Is it a line ending issue?
Seems to have been introduced in 113e8bd.
Same for better_sqlite3.hpp.
There was a problem hiding this comment.
Aye .. looks like the system i pushed the changes from had different line endings set up :-/ ..
In the end this is ugly, but those .cpp and .hpp files are auto generated by lzz anyway. Maybe it would help if the line ending to be used is setup within the .gitattributes.
There was a problem hiding this comment.
No worries, happens to everyone at some point. The .gitattributes idea sounds good to me. Also, I didn't know those files were auto generated.
|
Thank you very much for the patch, by the way! |
|
can't wait to have this; recent electron fix critical issues on linux, and I'm currently locked out of those fixes because of this. I'm not the best C dev, but happy to help if I can to move that forward |
|
@rvion This should make it work:
|
Closed
johannes-vogel
pushed a commit
to cap-js/cds-dbs
that referenced
this pull request
Aug 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [better-sqlite3](https://github.com/WiseLibs/better-sqlite3) | [`11.1.2` -> `11.2.0`](https://renovatebot.com/diffs/npm/better-sqlite3/11.1.2/11.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>WiseLibs/better-sqlite3 (better-sqlite3)</summary> ### [`v11.2.0`](https://github.com/WiseLibs/better-sqlite3/releases/tag/v11.2.0) [Compare Source](https://github.com/WiseLibs/better-sqlite3/compare/v11.1.2...v11.2.0) #### What's Changed - Support builds for Electron v32 by [@​neoxpert](https://github.com/neoxpert) in [WiseLibs/better-sqlite3#1226 - Adding SQLITE_ENABLE_DBSTAT_VTAB by [@​mikeburgh](https://github.com/mikeburgh) in [WiseLibs/better-sqlite3#1228 #### New Contributors - [@​mikeburgh](https://github.com/mikeburgh) made their first contribution in [WiseLibs/better-sqlite3#1228 **Full Changelog**: WiseLibs/better-sqlite3@v11.1.2...v11.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/cap-js/cds-dbs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Electron v32 some classes and functions marked as deprecated have been removed and require adjustments. Also c++20 is now required by v8.