Attempt to unmount target before stopping with error message #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for pull request, could you add yellow warning for user, that we are unmounting the target? |
|
@WaxyMocha Sure, I've added a warning message in line with the other yellow warning messages currently present:
Is this sufficient, or is there supposed to be user confirmation in the GUI? (For reference, other popular USB imaging programs such as Etcher and Popsicle simply unmount the target without any warning, so doing this is not unprecedented.) |
|
Yes, I think it will be sufficient 😃, I will test it soon. |
WaxyMocha
approved these changes
Feb 27, 2021
WaxyMocha
added a commit
that referenced
this pull request
Feb 28, 2021
Changes: - Close #6, Use new logo created by @ragnilorenzo, - Merge #23, Add German translation, - Merge #24, Auto unmount source and target, - Merge #25, Download efi image instead of html page - Add category to desktop shortcut, - Many small fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if any partition on the target device is mounted (in device mode), or if the target partition is mounted (in partition mode), the process stops with an error message telling the user to unmount the target and try again.
This change automatically attempts to unmount the offending partition(s), and if unmounting is successful, allows the process to continue. This is especially useful on distributions where external drives are automatically mounted when connected.